Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdtdserver): restore serverconfig setting #2640

Merged
merged 5 commits into from Dec 2, 2019

Conversation

@h3o66
Copy link
Contributor

h3o66 commented Dec 2, 2019

Description

Fixes sdtd config issue after upgrade to the latest release of lgsm that no config is there in the standard anymore

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 4 commits Nov 30, 2019
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Dec 2, 2019

@dgibbs64

This comment has been minimized.

Copy link
Member

dgibbs64 commented Dec 2, 2019

was previously servercfg="${servicename}.xml" so needs to beservercfg="${selfname}.xml"

e271439#diff-afc68adeb86e6650a61933e13fa780baL136

@h3o66 h3o66 force-pushed the h3o66:fix/sdtd-config branch from 18cd2da to 92dd860 Dec 2, 2019
@h3o66

This comment has been minimized.

Copy link
Contributor Author

h3o66 commented Dec 2, 2019

was previously servercfg="${servicename}.xml" so needs to beservercfg="${selfname}.xml"

e271439#diff-afc68adeb86e6650a61933e13fa780baL136

done
changed that with last force push

@dgibbs64 dgibbs64 changed the base branch from develop to hotfix/v19.12.4 Dec 2, 2019
@dgibbs64 dgibbs64 changed the title fix(sdtd): config back to the value before fix(sdtdserver): restore serverconfig setting Dec 2, 2019
@dgibbs64 dgibbs64 merged commit 0b9fbfc into GameServerManagers:hotfix/v19.12.4 Dec 2, 2019
3 of 4 checks passed
3 of 4 checks passed
Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
@h3o66 h3o66 deleted the h3o66:fix/sdtd-config branch Dec 2, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.