Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Unreal Tournament 4 #2644

Merged
merged 10 commits into from Mar 6, 2020

Conversation

@Frisasky
Copy link
Contributor

Frisasky commented Dec 6, 2019

Description

please allow me give a middle finger to epic for abandon this game

Fixes #1666

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

Frisasky added 6 commits Dec 6, 2019
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Dec 6, 2019

Score: 0.95

Best reviewed: commit by commit


Optimal code review plan (1 warning)

     Update install_server_files.sh

     Update info_parms.sh

     Update info_config.sh

     Update info_messages.sh

     Update serverlist.csv

Update _default.cfg

...fig-lgsm/utserver/_default.cfg 50% changes removed in Update _default.cfg

     Update _default.cfg

     query not working session only

     updated url to use linuxgsm download location

     remove query port as not functioning

Powered by Pull Assistant. Last update e6930f3 ... 36c557a. Read the comment docs.

@Frisasky Frisasky requested a review from dgibbs64 Dec 6, 2019
@Frisasky Frisasky changed the title feat(newserver): Unreal Tournament feat(newserver): Unreal Tournament 4 Dec 6, 2019
@@ -1239,7 +1239,14 @@ fn_info_message_unturned(){
} | column -s $'\t' -t
}


fn_info_message_ut(){
echo -e "netstat -atunp | grep UE4Server"

This comment has been minimized.

Copy link
@dgibbs64

dgibbs64 Dec 10, 2019

Member

A port is currently missing from details

DESCRIPTION  DIRECTION  PORT  PROTOCOL
> Game       INBOUND    7777  udp
udp        0      0 0.0.0.0:7777            0.0.0.0:*                           25331/./UE4Server-L 
udp        0      0 0.0.0.0:7787            0.0.0.0:*                           25331/./UE4Server-L
querymode="1"
querytype=""
querymode="3"
querytype="protocol-valve"

This comment has been minimized.

Copy link
@dgibbs64

dgibbs64 Dec 10, 2019

Member

Query is not currently working please review.

This comment has been minimized.

@dgibbs64 dgibbs64 merged commit 9f91d4e into GameServerManagers:develop Mar 6, 2020
3 of 4 checks passed
3 of 4 checks passed
Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
@dgibbs64 dgibbs64 added this to the v20.1.0 milestone Mar 9, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.