Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mcserver): update minecraft server to support release branches #2696

Merged
merged 4 commits into from Mar 8, 2020

Conversation

@Donkie
Copy link
Contributor

Donkie commented Mar 3, 2020

Description

Fixes #2703

Currently, the update script will only fetch the latest stable release. With this update, you can select snapshot as branch instead, which will download the latest snapshot/pre-release/release version.

Not sure about documentation, Minecraft doesn't have any existing docs page that explains the current special config items, so I guess this doesn't need one either?

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 3, 2020

@Donkie

This comment has been minimized.

Copy link
Contributor Author

Donkie commented Mar 5, 2020

@dgibbs64 Do I need to create an issue in order to get this merged?

@dgibbs64

This comment has been minimized.

Copy link
Member

dgibbs64 commented Mar 5, 2020

@Donkie If you could that would be great. I am running behind currently as I have been very busy at home with family stuff. Hopefully will be back to it soon.

@dgibbs64 dgibbs64 merged commit f2c8501 into GameServerManagers:develop Mar 8, 2020
3 of 4 checks passed
3 of 4 checks passed
Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
@dgibbs64 dgibbs64 added this to the v20.1.0 milestone Mar 9, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.