Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): use a new linuxgsm domain linuxgsm.download for files #2698

Merged
merged 2 commits into from Mar 6, 2020

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Mar 6, 2020

Non-steam downloads require hosting by LinuxGSM. Certain distros can be sensitive to changes in SSL and have previously prevented downloads working. A new domain linuxgsm.download has been created to separate linuxgsm.com and its files. This will ensure that linuxgsm.com can remain fully SSL compliant without accidentally breaking downloads

Description

Please include a summary of the change and which issues are fixed.

Fixes #2699

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

This will separate out linuxgsm files from the main domain to reduce the change of an ssl change breaking downloads
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 6, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     feat(install): use a new linuxgsm domain linuxgsm.download

     Merge branch 'develop' into feature/new-domain

Powered by Pull Assistant. Last update e6dbede ... e303e16. Read the comment docs.

@dgibbs64 dgibbs64 merged commit 0ea6a6e into develop Mar 6, 2020
3 of 5 checks passed
3 of 5 checks passed
Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
prosebot No relevant files
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/new-domain branch Mar 6, 2020
@dgibbs64 dgibbs64 added this to the v20.1.0 milestone Mar 9, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.