Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stats): fix stats bugs with language and sending stats #2727

Merged
merged 10 commits into from Mar 10, 2020

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Mar 10, 2020

Description

Bugfix language issue where is non-english extra words would appear in stats.
Swapped around event action and event label to make tables more consistent. This will cause some issues with displaying data for a while until all users update.

Fixes #2741

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 8 commits Dec 4, 2019
Done to better display and order information on google analytics
… feature/stats-improvements
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 10, 2020

Score: 0.68

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

     Merge branch 'hotfix/v19.12.5'

     release v19.12.5

Update info_stats.sh

lgsm/functions/info_stats.sh 75% changes removed in changes

     added cpu frequency

feat: swaped event label and event action

lgsm/functions/info_stats.sh 91% changes removed in changes

     Merge remote-tracking branch 'origin/feature/stats-improvements' into ...

     fix: prevent df from displaying non english text with disk space vars

     fix force english language on df to ensure a point is used

     changes

     return

Powered by Pull Assistant. Last update c1a6410 ... 0ecb5a4. Read the comment docs.

dgibbs64 added 2 commits Mar 10, 2020
@dgibbs64 dgibbs64 merged commit 466bc15 into develop Mar 10, 2020
6 checks passed
6 checks passed
prosebot No relevant files
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/stats-improvements branch Mar 10, 2020
@dgibbs64 dgibbs64 added this to the v20.1.0 milestone Mar 10, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.