Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert commandname to modulename #2728

Merged
merged 40 commits into from Mar 10, 2020
Merged

feat: convert commandname to modulename #2728

merged 40 commits into from Mar 10, 2020

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Mar 10, 2020

Description

Please include a summary of the change and which issues are fixed.

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 30 commits Oct 20, 2019
bug
bc
bug
MB
dgibbs64 added 8 commits Oct 22, 2019
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 10, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan (10 warnings)

     initial commit

move code

...m/functions/command_monitor.sh 83% changes removed in Merge branch 'develo...

     correct var

     anonymous ip

added game

...sm/functions/info_analytics.sh 50% changes removed in add uuid

add uuid

...sm/functions/info_analytics.sh 44% changes removed in analytics roundup

     correct if

remove dev/null

...sm/functions/info_analytics.sh 50% changes removed in removed info_analyti...

     add uuid var

     game server analytics

bug

...sm/functions/info_analytics.sh 50% changes removed in added if to only rep...

     percentage

added if to only report if data available

...sm/functions/info_analytics.sh 44% changes removed in bug

cpufrequency removed mhz

...sm/functions/info_analytics.sh 50% changes removed in adde cpuusedmhz

     adde cpuusedmhz

cpuusedmhz

...sm/functions/info_analytics.sh 50% changes removed in mhz symbol

     bc

     bc changes

     mhz symbol

     memused

analytics roundup

...sm/functions/info_analytics.sh 50% changes removed in removed info_analyti...

     remove MB

bug

...sm/functions/info_analytics.sh 75% changes removed in corrected vars

     MB

     moved analytics

     no round up for disk

     correct cpufreqency

     removed column

     correctedvar

     corrected vars

     correct vars

     moved analytics

     level 3 analytics

     corrected var

     var changes

     changed commandname to modulename

     Merge branch 'develop' into feature/topvars

     converted last to modulename

     added mew servers

     removed info_analytics

Powered by Pull Assistant. Last update 6e407af ... 2d2a566. Read the comment docs.

@dgibbs64 dgibbs64 changed the title Feature/topvars feat: convert commandname to modulename Mar 10, 2020
@dgibbs64

This comment has been minimized.

Copy link
Member Author

dgibbs64 commented Mar 10, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

See the complete overview on Codacy

dgibbs64 added 2 commits Mar 10, 2020
@dgibbs64 dgibbs64 merged commit d106384 into develop Mar 10, 2020
5 checks passed
5 checks passed
prosebot No relevant files
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/topvars branch Mar 10, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.