Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rm command best practices #2729

Merged
merged 3 commits into from Mar 10, 2020
Merged

feat: rm command best practices #2729

merged 3 commits into from Mar 10, 2020

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Mar 10, 2020

Description

strengthen rm command by using rm command best practices.

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 10, 2020

Score: 0.97

Best reviewed: commit by commit


Optimal code review plan (1 warning)

feat: prevent dirs expanding with rm command

...sm/functions/check_steamcmd.sh 71% changes removed in correct merge

     Merge branch 'develop' into feature/rm-strengthen

     correct merge

Powered by Pull Assistant. Last update f5caeab ... 30e5400. Read the comment docs.

@dgibbs64 dgibbs64 merged commit 3a6f7f9 into develop Mar 10, 2020
4 checks passed
4 checks passed
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/rm-strengthen branch Mar 10, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.