Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: general code standards improvements #2730

merged 6 commits into from Mar 10, 2020

feat: general code standards improvements #2730

merged 6 commits into from Mar 10, 2020


Copy link

dgibbs64 commented Mar 10, 2020


Please include a summary of the change and which issues are fixed.

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).


PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.


If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!


This comment has been minimized.

Copy link

pull-assistant bot commented Mar 10, 2020

Score: 0.98

Best reviewed: commit by commit

Optimal code review plan (1 warning)

add missing space in ; then

...gsm/functions/ 50% changes removed in standardised True if...

     standardise command if

     standardised True if the length of "STRING" is non-zero.

     changed -e to -f

     Merge remote-tracking branch 'origin/develop' into feature/standards

     Merge branch 'develop' into feature/standards

Powered by Pull Assistant. Last update 9ae3bf0 ... 05cd16d. Read the comment docs.

@dgibbs64 dgibbs64 merged commit abaa614 into develop Mar 10, 2020
3 of 5 checks passed
3 of 5 checks passed
Travis CI - Branch Build Errored
Travis CI - Pull Request Build Errored
prosebot No relevant files
Semantic Pull Request ready to be squashed
WIP Ready for review
@delete-merged-branch delete-merged-branch bot deleted the feature/standards branch Mar 10, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.