Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardise config vars and fix session only monitor #2736

Merged
merged 13 commits into from Mar 13, 2020

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Mar 13, 2020

Description

Please include a summary of the change and which issues are fixed.

Fixes #2738

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 13 commits Mar 11, 2020
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 13, 2020

Score: 0.93

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

     fix(monitor_: bypass port query if session only mode selected

     removed factorio queryport

     remove queryport from servers that do not use them

     add check_config to details command

     updated eco servercfgdir

     update _default.cfg test

update _default.cfg test

...defaultcfg/tests_defaultcfg.sh 50% changes removed in tidy configs

     update test master config

     re ordered servercfg vars

re-ordered and standardised config file vars

...ig-lgsm/jc3server/_default.cfg 50% changes removed in standardised serverc...

...-lgsm/onsetserver/_default.cfg 50% changes removed in standardised serverc...

...ig-lgsm/ts3server/_default.cfg 50% changes removed in standardised serverc...

...g-lgsm/fctrserver/_default.cfg 50% changes removed in standardised serverc...

...fig-lgsm/mcserver/_default.cfg 50% changes removed in standardised serverc...

...ig-lgsm/ecoserver/_default.cfg 50% changes removed in standardised serverc...

...ig-lgsm/jc2server/_default.cfg 50% changes removed in standardised serverc...

...lgsm/mumbleserver/_default.cfg 50% changes removed in standardised serverc...

...fig-lgsm/sbserver/_default.cfg 50% changes removed in standardised serverc...

...sm/terrariaserver/_default.cfg 50% changes removed in standardised serverc...

...ig-lgsm/mcbserver/_default.cfg 50% changes removed in standardised serverc...

...fig-lgsm/qlserver/_default.cfg 50% changes removed in standardised serverc...

...fig-lgsm/twserver/_default.cfg 50% changes removed in standardised serverc...

...-lgsm/mohaaserver/_default.cfg 50% changes removed in standardised serverc...

...fig-lgsm/rwserver/_default.cfg 50% changes removed in standardised serverc...

     tidy configs

     shellcheck

     standardised servercfgdir

Powered by Pull Assistant. Last update fa7fceb ... 64a0dc9. Read the comment docs.

@dgibbs64 dgibbs64 added this to the v20.1.0 milestone Mar 13, 2020
@dgibbs64 dgibbs64 merged commit 306faa9 into develop Mar 13, 2020
5 checks passed
5 checks passed
Milestone Check Great, the milestone is set.
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/monitor-session branch Mar 13, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
@dgibbs64 dgibbs64 linked an issue that may be closed by this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.