Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arkserver): refactor and simplify how ark mods work #2773

Merged
merged 12 commits into from Mar 21, 2020

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Mar 21, 2020

Description

refactor and simplify how ark mods work. After much testing and feedback Ark mods now work as expected using -automanagedmods.

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 12 commits Mar 21, 2020
fix
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 21, 2020

Score: 0.74

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

yet another ark mod fix

lgsm/functions/fix_ark.sh 85% changes removed in further improvements

testing downloading steamcmd instead of symlink

lgsm/functions/fix_ark.sh 57% changes removed in correct if for detec...

     fix

     comment out

     further improvements

     moved steamcmd clear function order

     new fix for possible problems

     correct unlink dir

     correct if for detecting symlink

     added if symlink exists

     add check_steamcmd.sh to re-check steamcmd exists

     more fixes

Powered by Pull Assistant. Last update 86d8e14 ... 1dbf42c. Read the comment docs.

@dgibbs64 dgibbs64 added this to the v20.1.4 milestone Mar 21, 2020
@dgibbs64 dgibbs64 merged commit bb86a85 into hotfix/v20.1.4 Mar 21, 2020
5 of 6 checks passed
5 of 6 checks passed
pull_request_label Labels not setup correctly
Details
Milestone Check Great, the milestone is set.
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/fix-ark-mods-again branch Mar 21, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 21, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.