Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): SCP: Secret Laboratory #3163

Merged
merged 1 commit into from Jan 10, 2021

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jan 8, 2021

Description

Adds SCP: Secret Laboratory and SCP: Secret Laboratory ServerMod

Fixes #1995

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 added this to the v21.1.0 milestone Jan 10, 2021
@dgibbs64 dgibbs64 changed the title feat(scp): add new server feat(newserver): SCP: Secret Laboratory Jan 10, 2021
Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this. Will need some Docs adding to highlight the different versions

@dgibbs64 dgibbs64 merged commit 05e4570 into GameServerManagers:develop Jan 10, 2021
@h3o66 h3o66 deleted the feature/scp branch January 10, 2021 22:27
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: game server request Request for a new server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] SCP Secret Laboratory
2 participants