Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): server config text change for rcon #3175

Merged
merged 2 commits into from Jan 10, 2021
Merged

fix(rust): server config text change for rcon #3175

merged 2 commits into from Jan 10, 2021

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jan 10, 2021

Description

Changes the text in the lgsm default config to the requested text from the issue

Fixes #3174

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 requested a review from dgibbs64 January 10, 2021 21:43
@h3o66 h3o66 linked an issue Jan 10, 2021 that may be closed by this pull request
Comment update for rust servers #3174
Closed
@h3o66 h3o66 added this to the v21.1.0 milestone Jan 10, 2021
@dgibbs64 dgibbs64 enabled auto-merge (squash) January 10, 2021 22:27
@dgibbs64 dgibbs64 merged commit 9cc0b3d into GameServerManagers:develop Jan 10, 2021
@h3o66 h3o66 deleted the fix/rust-server-rcon-text branch January 10, 2021 22:28
@dgibbs64 dgibbs64 added the type: feature request New feature or request label Jan 24, 2021
dgibbs64 added a commit that referenced this pull request Jan 25, 2021
@h3o66 @dgibbs64
fix(rust): server config text change for rcon (#3175)
b6f9ac8 
Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgibbs64 dgibbs64 dgibbs64 approved these changes

Assignees
No one assigned
Labels
game: Rust type: feature request New feature or request
Projects
None yet
Milestone
v21.1.0
Development

Successfully merging this pull request may close these issues.

Comment update for rust servers
2 participants
@h3o66 @dgibbs64