Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cod4): Improve servername and rcon password parsing #3564

merged 2 commits into from Sep 22, 2021


Copy link

@h3o66 h3o66 commented Sep 21, 2021


Fixes the servername parsing and make the parsing more simple overall with one sed

Fixes #3472

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).


PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.


If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added type: bug Something isn't working game: Call of Duty 4 labels Sep 21, 2021
@h3o66 h3o66 linked an issue Sep 21, 2021 that may be closed by this pull request
@dgibbs64 dgibbs64 self-requested a review September 22, 2021 20:05
Copy link

bolted on a few extra changes to this one :)

@dgibbs64 dgibbs64 added this to the v21.3.0 milestone Sep 22, 2021
@dgibbs64 dgibbs64 merged commit 5ca1803 into GameServerManagers:develop Sep 22, 2021
@h3o66 h3o66 deleted the fix/cod4-servername-3472 branch September 24, 2021 20:48
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
game: Call of Duty 4 type: bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[BUG] Unhandled single quote xargs error in cod4server
2 participants