Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telegram): resolve alert sending invalid json #3605

Merged
merged 1 commit into from Oct 10, 2021

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Oct 10, 2021

Description

The telegram alert was using invalid json (though telegram did accept it). JSON has been corrected and is now valid.

Fixes #3588

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

The telegram alert was using invalid json (though telegram did accept it). JSON has been corrected and is now valid
@dgibbs64 dgibbs64 added this to the v21.3.2 milestone Oct 10, 2021
@dgibbs64 dgibbs64 linked an issue Oct 10, 2021 that may be closed by this pull request
@dgibbs64 dgibbs64 merged commit 44daf20 into hotfix/v21.3.2 Oct 10, 2021
@dgibbs64 dgibbs64 deleted the feature/3588-telegram branch October 10, 2021 21:34
@dgibbs64 dgibbs64 removed the feature label Oct 10, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Issue faced with Telegram Alerts post update of LGSM core files
1 participant