Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1868 mods lowercase conversion #3717

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

UltimateByte
Copy link
Contributor

Description

Major refactor of fn_mod_lowercase()
Finally fixes mods lowercase conversion

Fixes #1868

Type of change

  • Bug fix (a change which fixes an issue).

Sample output

Installing DarkRP
=================================
creating mod download directory /home/ulti/lgsm/mods/tmp...OK
                                #=#=-  #       #                                                                                                                                                                                                       ################################################################################################################################################################################################################################################ 100.0%   -#O=-   #         #           #                                                                                                                                                                                                                    
extracting darkrp-master.zip...OK
converting DarkRP files to lowercase...Found 19 uppercase files out of 588, converting...OK
building darkrp-files.txt...OK
copying DarkRP to /home/ulti/serverfiles/garrysmod/gamemodes...OK
tidy up darkrp-files.txt...OK
clearing mod download directory /home/ulti/lgsm/mods/tmp...OK
DarkRP installed

# ls serverfiles/garrysmod/gamemodes/darkrp-master/
 content   contributing.md   darkrp.txt  "don't touch any of these files.txt"   entities   gamemode   glualint.json   help   icon24.png   issue_template.md   license.txt   logo.png   readme.md

Sample output:
Installing DarkRP
=================================
creating mod download directory /home/ulti/lgsm/mods/tmp...OK
                                #=#=-  #       #                                                                                                                                                                                                       ################################################################################################################################################################################################################################################ 100.0%   -#O=-   #         #           #                                                                                                                                                                                                                    
extracting darkrp-master.zip...OK
converting DarkRP files to lowercase...Found 19 uppercase files out of 588, converting...OK
building darkrp-files.txt...OK
copying DarkRP to /home/ulti/serverfiles/garrysmod/gamemodes...OK
tidy up darkrp-files.txt...OK
clearing mod download directory /home/ulti/lgsm/mods/tmp...OK
DarkRP installed
@UltimateByte UltimateByte changed the title Finally fixes #1868 mods lowercase conversion fix: #1868 mods lowercase conversion Dec 18, 2021
@dgibbs64 dgibbs64 requested a review from h3o66 December 20, 2021 23:47
Copy link
Member

@h3o66 h3o66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with a first test with gmod darkrp

@dgibbs64 dgibbs64 added this to the v21.5.0 milestone Dec 21, 2021
@dgibbs64 dgibbs64 merged commit de6240f into GameServerManagers:develop Dec 21, 2021
jusito pushed a commit to jusito/LinuxGSM that referenced this pull request Aug 24, 2022
…agers#3717)

* Finally fixes GameServerManagers#1868 mods lowercase conversion 

Sample output:
Installing DarkRP
=================================
creating mod download directory /home/ulti/lgsm/mods/tmp...OK
                                #=#=-  #       #                                                                                                                                                                                                       ################################################################################################################################################################################################################################################ 100.0%   -#O=-   #         #           #                                                                                                                                                                                                                    
extracting darkrp-master.zip...OK
converting DarkRP files to lowercase...Found 19 uppercase files out of 588, converting...OK
building darkrp-files.txt...OK
copying DarkRP to /home/ulti/serverfiles/garrysmod/gamemodes...OK
tidy up darkrp-files.txt...OK
clearing mod download directory /home/ulti/lgsm/mods/tmp...OK
DarkRP installed

* removed unused variable
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants