Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(details): check as well queryport via steam #3719

Merged
merged 1 commit into from Dec 20, 2021

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Dec 19, 2021

Description

check master server status even if the main port is not used on the steam api
Includes a change for the games that support the new change

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66
Copy link
Member Author

h3o66 commented Dec 19, 2021

Note: needed for the upcomming "The Isle" Linux Server, as it does use the query port on the steam api.

@h3o66 h3o66 mentioned this pull request Dec 19, 2021
13 tasks
@h3o66 h3o66 force-pushed the feature/dt-steamquery branch 5 times, most recently from 42abe17 to bd55ef5 Compare December 20, 2021 18:41
@dgibbs64 dgibbs64 added this to the v21.5.0 milestone Dec 20, 2021
@dgibbs64 dgibbs64 merged commit 4b95e7f into GameServerManagers:develop Dec 20, 2021
@h3o66 h3o66 deleted the feature/dt-steamquery branch December 20, 2021 21:17
jusito pushed a commit to jusito/LinuxGSM that referenced this pull request Aug 24, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants