Fix(tmux): better tmux session handling for multiple instance on same server / user session #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…game instance to avoid sharing same pid.
cclecle
changed the title
|
Not sure about this one. |
|
Caution needs to happen with tmux changes. Problems have occurred before. I will need to review and test :) |
dgibbs64
force-pushed
the
develop
branch
5 times, most recently
from
f02e53d to
2257be4
Compare
This commit refactors the code to improve consistency in the usage of the `tmux` command. It adds the `-L` flag followed by the session name to all `tmux` commands. This ensures that all commands are executed within the correct session. Additionally, it updates the `check_status.sh`, `command_console.sh`, `command_send.sh`, `command_start.sh`, `command_stop.sh`, and `info_distro.sh` files to include this change. The changes ensure that all relevant commands are executed within the specified session, improving code readability and maintainability.
dgibbs64
approved these changes
Jul 20, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Force tmux to create a new trmux server instance for each game instance to avoid sharing same pid.
This allow systemd to differentiate games server instance correctly.
Update consist to change:
tmux <some options>with:
tmux -L "${sessionname}" <some options>Fixes #3763
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
No update needed.