Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Arma Reforger #3871

Merged
merged 11 commits into from
Jun 2, 2022

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented May 21, 2022

Description

Add Arma Reforger server

Fixes #3872

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 mentioned this pull request May 21, 2022
13 tasks
@h3o66 h3o66 marked this pull request as ready for review May 23, 2022 17:47
@h3o66 h3o66 added this to the v22.1.0 milestone May 23, 2022
@Marcin648
Copy link
Contributor

Marcin648 commented May 23, 2022

Linux distribution compatibility tests

All tests are run using fresh LXD containers.
Tested auto installation and server start.

Distro Result Comment
ubuntu/22.04 libssl1.1 unavailable
ubuntu/20.04 ✔️
ubuntu/18.04 ✔️
debian/11 ✔️
debian/10 ✔️
debian/9 libcurl4 unavailable, glibc too old
centos/8-Stream ✔️
centos/7 glibc too old

@FliesWithWind
Copy link
Contributor

FliesWithWind commented May 24, 2022

@Marcin648 Workaround for Ubuntu 22.04 would require to add repo to sources list. The question is if this would be acceptable as a "fix" script, or we could simply print instructions for it, for users to do it manually.

echo "deb http://security.ubuntu.com/ubuntu impish-security main" | sudo tee /etc/apt/sources.list.d/impish-security.list
sudo apt-get update
sudo apt-get install libssl1.1

@Marcin648
Copy link
Contributor

Marcin648 commented May 25, 2022

@FliesWithWind like @h3o66 said on discord, I have a similar opinion about this workaround. Adding repositories from other distro version is not recommended. Other workaround is direct download .deb, and install it by dpkg. But this also not recommended because package like that don't be supported by updates and OpenSSL is critical security library. In my opinion good way to install Arma Reforger server on Ubuntu 22.04 is install it in LXD or docker container with Ubuntu 20.04.

@h3o66 h3o66 linked an issue May 29, 2022 that may be closed by this pull request
4 tasks
port=$(jq -r '.gameHostBindPort' "${servercfgfullpath}")
queryport=$(jq -r '.steamQueryPort' "${servercfgfullpath}")
servername=$(jq -r '.game.name' "${servercfgfullpath}")
serverpassword=$(jq -r '.game.password' "${servercfgfullpath}")
maxplayers=$(jq -r '.game.playerCountLimit' "${servercfgfullpath}")
adminpassword=$(jq -r '.adminPassword' "${servercfgfullpath}")
battleeyeport=1376
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm that 1376 is a BattlEye port. I don't found any information about this in official documentation. On official Arma discord this port is call "unknown" and can be close.

Copy link
Contributor

@FliesWithWind FliesWithWind Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BattlEye port can be set by creating BEServer_x64.cfg in battleye folder.

RConIP 192.168.99.99
RConPort 9999
RConPassword rcon_password

Copy link
Contributor

@Marcin648 Marcin648 Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. BattlEye RCON port is not the same that be client port. For example in Arma3 if BE is enabled, they listen on game port + 4 UDP, but if is disabled they don't. In armar always listen on port 1376. ¯\(ツ)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgibbs64
Copy link
Member

dgibbs64 commented Jun 2, 2022

I will make a note that 22.04 is not yet supported on the website when it is added

@dgibbs64 dgibbs64 merged commit c68394f into GameServerManagers:develop Jun 2, 2022
@h3o66 h3o66 deleted the feature/armar branch June 3, 2022 07:19
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] - Arma Reforger
4 participants