Skip to content

feat(mcb): allow to set hard a version for the server #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented May 30, 2022

Description

Allows to pin the version for a download to a version.
Either latest or the accurate version of the download is needed here.

Fixes #3879

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 linked an issue May 30, 2022 that may be closed by this pull request
@h3o66 h3o66 added this to the v22.1.0 milestone May 30, 2022
@h3o66
Copy link
Member Author

h3o66 commented May 30, 2022

Note: this also removes duplicate code

@dgibbs64 dgibbs64 merged commit 14ca894 into GameServerManagers:develop May 31, 2022
@h3o66 h3o66 deleted the feature/3879-mcb-pin-version branch June 1, 2022 19:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] MCB: Allow game to be updated to a specific version
2 participants