Skip to content

feat: game server config migration #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat: game server config migration #4262

merged 2 commits into from
Jul 12, 2023

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Jul 12, 2023 •
edited
Loading

Description

Migrates configs from master to main branch. using shortname instead of gamedirname

Fixes #4237

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 2 commits July 12, 2023 11:53
@dgibbs64
refactor: simplify game directory names in install_config.sh
a9593fd 
The commit simplifies the game directory names in the install_config.sh file. It replaces specific game directory names with a generic variable, shortname, to improve code readability and maintainability.
@dgibbs64
fix: handle invalid directory paths
369f527 
The code now checks if the server files or system directory exist before proceeding. If either directory does not exist, an error message is printed and the script exits.
@dgibbs64 dgibbs64 changed the title Feature/config migrate feat: game server config migration Jul 12, 2023
@dgibbs64 dgibbs64 added this to the v23.4.0 milestone Jul 12, 2023
@dgibbs64 dgibbs64 merged commit d34bc29 into develop Jul 12, 2023
@dgibbs64 dgibbs64 deleted the feature/config-migrate branch July 12, 2023 11:17
@dgibbs64 dgibbs64 linked an issue Jul 21, 2023 that may be closed by this pull request
[Feature]: Migrate naming convetion of GameServerConfigs repo #4237
Closed
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
type: refactor
Projects
None yet
Milestone
v23.4.0
Development

Successfully merging this pull request may close these issues.

[Feature]: Migrate naming convetion of GameServerConfigs repo
1 participant
@dgibbs64