Skip to content

Bug/overlay csv fixes #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Bug/overlay csv fixes #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2537867
Fix for invalid mMsBetweenDisplayChange push back
markgalvan-intel May 20, 2025
9a1f8eb
Add Instrumented Latency to list of metrics where NA means not availa…
markgalvan-intel May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion IntelPresentMon/Core/source/pmon/RawFrameDataWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ namespace p2c::pmon
metricId == PM_METRIC_BETWEEN_SIMULATION_START ||
metricId == PM_METRIC_PC_LATENCY ||
metricId == PM_METRIC_BETWEEN_DISPLAY_CHANGE ||
metricId == PM_METRIC_UNTIL_DISPLAYED ) {
metricId == PM_METRIC_UNTIL_DISPLAYED ||
metricId == PM_METRIC_INSTRUMENTED_LATENCY) {
flags |= Annotation_::FLAG_NAN_MEANS_NOT_AVAILABLE;
}

Expand Down
7 changes: 6 additions & 1 deletion IntelPresentMon/PresentMonMiddleware/ConcreteMiddleware.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,9 +806,14 @@ static void ReportMetricsHelper(
if (displayed) {
chain->mDisplayLatency .push_back(metrics.mDisplayLatency);
chain->mDisplayedTime .push_back(metrics.mDisplayedTime);
chain->mMsBetweenDisplayChange .push_back(metrics.mMsBetweenDisplayChange);
chain->mMsUntilDisplayed .push_back(metrics.mMsUntilDisplayed);
chain->mDropped .push_back(0.0);
if (metrics.mMsBetweenDisplayChange != 0) {
// Only push back the mMsBetweenDisplayChange if it is non-zero.
// mMsBetweenDisplayChange will be zero on the first use of the incoming
// swap chain parameter.
chain->mMsBetweenDisplayChange.push_back(metrics.mMsBetweenDisplayChange);
}
} else {
chain->mDropped .push_back(1.0);
}
Expand Down