New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of hard coded secret #56

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@rastating
Copy link

rastating commented Jun 1, 2018

Description
This pull request fixes a security issue by removing the hard coded cookie secret. This change will instead make the application fetch it from the environment variable GAMERPOLLS_COOKIE_SECRET.

By using a hard coded secret, a would-be attacker could manipulate the cookie data and re-sign it using the same cookie secret - potentially leading to an authentication bypass and privilege escalation.

Vulnerability Classification
CWE-259: Use of Hard-coded Password
CWE-302: Authentication Bypass by Assumed-Immutable Data

CVE-ID
CVE-2018-10966

CVSS v3 Score
6.5 (Medium)

CVSS v3 Vector
AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:L/A:N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment