This repository has been archived by the owner on Nov 7, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a security issue by removing the hard coded cookie secret. This change will instead make the application fetch it from the environment variable
GAMERPOLLS_COOKIE_SECRET
.By using a hard coded secret, a would-be attacker could manipulate the cookie data and re-sign it using the same cookie secret - potentially leading to an authentication bypass and privilege escalation.
Vulnerability Classification
CWE-259: Use of Hard-coded Password
CWE-302: Authentication Bypass by Assumed-Immutable Data
CVE-ID
CVE-2018-10966
CVSS v3 Score
6.5 (Medium)
CVSS v3 Vector
AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:L/A:N