fix: no internet connection handler (#265) Resolves #262

* fetcher - error handler | prevent internet connection related error from being reported

* fcm - offline | notification setup disable if device offline

* Fetcher - HTTP error handler | move the internet connection check at the top

Author: bricefriha

App/Services/Fetcher.cs

@@ -83,7 +83,7 @@ public async Task<Collection<Source>> GetSources()
     {
         return Fetcher.Sources =  await WebService.Get<Collection<Source>>(controller: "sources", 
                                                         action: "getAll",
-                                                         unSuccessCallback: e => _ = HandleHttpException(e));
+                                                        unSuccessCallback: e => _ = HandleHttpException(e));
     }
     /// <summary>
     /// Get the feed of an article
@@ -429,10 +429,16 @@ public void SaveUserInfo(User user)
     /// <exception cref="Exception"></exception>
     private async Task HandleHttpException(HttpResponseMessage err)
     {
+        string errMsg = await err.Content.ReadAsStringAsync();
+
+        if (Connectivity.Current.NetworkAccess != NetworkAccess.Internet
+            && (errMsg.Contains("internet connection") || errMsg.Contains("Connection failure")))
+            // If the error is being thrown because there is no internet: there is no point reporting it 
+            return;
 #if DEBUG
-        throw new Exception(await err.Content.ReadAsStringAsync());
+        throw new Exception(errMsg);
 #else
-        SentrySdk.CaptureException(new Exception(await err.Content.ReadAsStringAsync()));
+        SentrySdk.CaptureException(new Exception(errMsg));
 #endif
     }
 

App/ViewModels/AppShellViewModel.cs

@@ -127,6 +127,9 @@ public async Task UpdateDeals()
     /// </summary>
     public async Task NotificationSetup()
     {
+        if (Connectivity.Current.NetworkAccess != NetworkAccess.Internet)
+            return;
+
         if ((await _firebasePushPermissions.GetAuthorizationStatusAsync() is not Plugin.FirebasePushNotifications.Model.AuthorizationStatus.Granted)
             && Preferences.Get(_notificationKey, true))
 #if ANDROID