Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header for JP language #1407

Closed
wants to merge 1 commit into
base: development
from

Conversation

Projects
None yet
1 participant
@chibicode
Copy link

chibicode commented Feb 13, 2019

Hello, this is Shu, a Japanese translator for Factfulness who just got invited to Gapminder Slack.

There's a translation bug for JP language regarding prepositions like "of" or "in". In Japanese, many prepositions like "of" or "in" must be placed after the word instead of before. So instead of "A of B", in Japanese you must do "B {{ 'of' | translate }} A".

I added the logic on LanguageService and used it on the Header component. This might not be the best way (as there are many other places that use {{ 'IN' | translate }}), but at least fixes the header (the most prominent UI) for the Japanese audience.

Before (Incorrect)

screen shot 2019-02-13 at 12 37 10 pm

screen shot 2019-02-13 at 12 37 28 pm

After (Correct)

screen shot 2019-02-13 at 12 25 26 pm

screen shot 2019-02-13 at 12 41 26 pm

@chibicode chibicode force-pushed the chibicode:japanese-page-fixes branch from e73ea0d to 29a65df Feb 13, 2019

@chibicode chibicode force-pushed the chibicode:japanese-page-fixes branch from 29a65df to 183c906 Feb 13, 2019

@chibicode

This comment has been minimized.

Copy link
Author

chibicode commented Mar 10, 2019

This is fixed. Thank you!

@chibicode chibicode closed this Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.