Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling under Android Studio #405

Merged

Conversation

dottools
Copy link
Contributor

@dottools dottools commented Feb 5, 2018

This PR fixes building and running under current Android Studio IDE stable release along with current Gradle build system.

Important Highlights:

  • Changed APP_STL to c++_static as stlport_static is depreciated and broken in latest NDK anyway.
  • Current compiler has RTTI disabled by default so C++ compiler flags updated to explicitly enable RTTI.
  • Minimum SDK version changed from 16 -> 19.
  • Minimum build tools is now 26.0.2 as required for current Android SDK.
  • Torque's strstr variant wasn't standard library compliant and has been fixed for all platforms that Torque 2D compiles for and runs on. Was explicitly corrected for Android Studio because current compiler refuses to allow old/incorrect usages.
  • All Android platform build specific warnings have been fixed.

Minimum build tools is now 26.0.2 as required for current Android SDK.
Minimum SDK version changed from 16 -> 19 as required to use SYSTEM_UI_FLAG_IMMERSIVE_STICKY.
Fix unknown symbol `Bundle` error.
Changed APP_STL to `c++_static` as `stlport_static` is depreciated and broken in latest NDK anyway.
Current compiler has RTTI disabled by default so C++ compiler flags updated to explicitly enable RTTI.
Torque's `strstr` variant wasn't standard library compliant and has been fixed for all platforms that Torque 2D compiles for and runs on. Was explicitly corrected for Android Studio because current compiler refuses to allow old/incorrect usages.
Fixed pointer comparison to integer error, another thing not allowed by current compiler.
Fixed `free` and `malloc` undeclared function warnings.
delegateSignal.h's `_SIGNAL_H_` header guard collided with Unix signal.h's header guard, changed to `_DELEGATESIGNAL_H_`.
@greenfire27
Copy link
Contributor

Awesome! Thanks for doing this.

@greenfire27 greenfire27 merged commit 1b16cbf into GarageGames:development Feb 5, 2018
@dottools dottools mentioned this pull request Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants