New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Editor moveSelection #1097

Closed
Packer opened this Issue Jan 9, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@Packer

Packer commented Jan 9, 2015

Currently in the development branch moveSelection (Or Nudging in the F10 GUI Editor) is broken, its getting 4 variables when it only wants 3, I looked into it and the moveSelection is only taking the first variable in the engine.

Engine\source\gui\editor\guiEditCtrl.cpp

New broken code:
DefineConsoleMethod( GuiEditCtrl, moveSelection, void, (Point2I pos), , "Move all controls in the selection by (dx,dy) pixels.")
{
object->moveAndSnapSelection(Point2I(pos));
}
Old Working Code:
ConsoleMethod( GuiEditCtrl, moveSelection, void, 4, 4, "(int dx, int dy) - Move all controls in the selection by (dx,dy) pixels.")
{
object->moveAndSnapSelection(Point2I(dAtoi(argv[2]), dAtoi(argv[3])));
}

@crabmusket crabmusket added the Bug label Jan 9, 2015

@crabmusket crabmusket added this to the 3.7 milestone Jan 9, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jan 9, 2015

Contributor

Ah dear, this was because of #1072 (specifically, this). @Winterleaf changed some APIs which I haven't been diligent enough in checking. Thanks for the report, this will be an easy fix.

Contributor

crabmusket commented Jan 9, 2015

Ah dear, this was because of #1072 (specifically, this). @Winterleaf changed some APIs which I haven't been diligent enough in checking. Thanks for the report, this will be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment