Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in script templates #1112

Closed
crabmusket opened this issue Jan 19, 2015 · 3 comments
Closed

Reduce duplication in script templates #1112

crabmusket opened this issue Jan 19, 2015 · 3 comments
Assignees

Comments

@crabmusket
Copy link
Contributor

@crabmusket crabmusket commented Jan 19, 2015

As per this forum thread, we will introduce a Packages folder to split duplicated script modules into single locations. For example, where we now have something like:

Templates/
    Full/
        tools/
    Empty/
        tools/

This change will result in:

Templates/
    Full/
    Empty/
Packages/
    Editor/
        tools/

When a project is created, desired packages are copied into the project directory the same way templates currently are. This means that instead of changing template scripts in two locations, the package can be changed, and all templates will benefit from the update.

This change will be fully backwards-compatible with 3.6 at the project level - i.e. a project created in 3.7 will look identical to a project created in 3.6. However, user modifications to the templates will have to be ported to the appropriate package.

For associated project generator changes, and an explanation of how templates specify which packages they need, see GarageGames/Torque3D-ProjectManager#36.

The major downside to this change will be that CMake does not currently handle the template.xml parsing and file copying needed to replace the work the project generator will do. We view this tradeoff as acceptable; CMake is still pretty much an 'experienced-users-only' option at the moment, and we're sure they can handle a couple of extra copy/pastes when creating a new project. Eventually, CMake will not be responsible for anything to do with the templates, anyway.

@crabmusket crabmusket added this to the 3.7 milestone Jan 19, 2015
@crabmusket crabmusket self-assigned this Jan 19, 2015
@LuisAntonRebollo
Copy link
Contributor

@LuisAntonRebollo LuisAntonRebollo commented Jan 19, 2015

👍

@crabmusket crabmusket added this to the 3.8 milestone Mar 4, 2015
@crabmusket crabmusket removed this from the 3.7 milestone Mar 4, 2015
@crabmusket
Copy link
Contributor Author

@crabmusket crabmusket commented Mar 4, 2015

Sigh :(

@crabmusket crabmusket removed this from the 3.8 milestone Jun 24, 2015
@crabmusket crabmusket added this to the 3.7 milestone Jun 24, 2015
@crabmusket crabmusket added this to the 3.7 milestone Jun 24, 2015
@crabmusket crabmusket removed this from the 3.8 milestone Jun 24, 2015
@crabmusket crabmusket removed this from the 3.7 milestone Jun 24, 2015
@crabmusket crabmusket removed this from the 3.7 milestone Jun 24, 2015
@Areloch
Copy link
Contributor

@Areloch Areloch commented Mar 28, 2016

The new template will largely take care of this.

@Areloch Areloch closed this Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants