Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Pull Request #1026 broke the console stack #1134
There have been numerous reports that the console stack is throwing out asserts in the development branch. I've tracked it down to a certain pull request of mine, PR 1026 (#1026). Intended to fix issue #976 .
It seems while it fixed the reported issue, it has the unintended side-effect of not cleaning the stack out correctly during future function calls.
I have a preliminary fix for this which resolves this by changing the stack behaviour of executef and the callback helpers (i.e. it makes them all go through templates which properly manage the stack). I'd like to write some basic tests however to ensure the new behaviour isn't breaking anything...