New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash 3.6.3 GUI Editor Locks Up #1181

Closed
SteveYorkshire opened this Issue Feb 11, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@SteveYorkshire

SteveYorkshire commented Feb 11, 2015

Keep getting a crash/lockup in the new 3.6.3. Stock code, built with Project Manager 2.2 beta (+ missing xml file)
Open GUI editor up and then close twice and it all crashes.
Note: not an issue in 3.6.2.

To reproduce method 1:
Start a level, start GUI editor (F10), close it, reopen GUI editor (F10), close it again and crash/lock.
The error which loops into eternity.
To reproduce method 2:
At MainMenu open GUI Editor, close it, open it again and close aghain and crash/lock.
To reproduce method 3:
Open GUI Editor once, then exit and quit Torque. Lots of errors but T3D will quit before it locks.

The error which loops to crash:

tools/guiEditor/scripts/guiEditorCanvas.ed.cs (223): Unknown command delete.
Object (4479) MenuBuilder

The script: tools/guiEditor/scripts/guiEditorCanvas.ed.cs

/// Called before onSleep when the canvas content is changed
function GuiEditCanvas::onDestroyMenu(%this)
{
if( !isObject( %this.menuBar ) )
return;

// Destroy menus
while( %this.menuBar.getCount() != 0 )
%this.menuBar.getObject( 0 ).delete();//yorks - here be dragons!

%this.menuBar.removeFromCanvas();
%this.menuBar.delete();
}

Thread I opened on the forums:
http://forums.torque3d.org/viewtopic.php?f=2&t=29

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 12, 2015

Contributor

Missing XML file? You mean this one? Also, this issue may be a duplicate of #1114.

Contributor

crabmusket commented Feb 12, 2015

Missing XML file? You mean this one? Also, this issue may be a duplicate of #1114.

@crabmusket crabmusket added the Bug label Feb 12, 2015

@SteveYorkshire

This comment has been minimized.

Show comment
Hide comment
@SteveYorkshire

SteveYorkshire Feb 12, 2015

Yes that does look like the same issue.
Still, the superClass MenuBuilder shouldn't be getting added to the set.
Also it still throws nasty console spam error same as my fix.
Including a whole host when you exit Torque.

tools/base/menuBar/menuBuilder.ed.cs (157): Unknown command removeFromMenuBar.
Object EditorInspectorBaseDatablockFieldPopup(2820) EditorInspectorBaseDatablockFieldPopup -> MenuBuilder

And yes, that xml file is/was not in the 2.2 beta zip.

SteveYorkshire commented Feb 12, 2015

Yes that does look like the same issue.
Still, the superClass MenuBuilder shouldn't be getting added to the set.
Also it still throws nasty console spam error same as my fix.
Including a whole host when you exit Torque.

tools/base/menuBar/menuBuilder.ed.cs (157): Unknown command removeFromMenuBar.
Object EditorInspectorBaseDatablockFieldPopup(2820) EditorInspectorBaseDatablockFieldPopup -> MenuBuilder

And yes, that xml file is/was not in the 2.2 beta zip.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 12, 2015

Contributor

It's not in the PM zip because it's included in the engine repo.

Contributor

crabmusket commented Feb 12, 2015

It's not in the PM zip because it's included in the engine repo.

@crabmusket crabmusket added this to the 3.7 milestone Feb 14, 2015

@crabmusket crabmusket self-assigned this Mar 1, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Mar 1, 2015

Contributor

@SteveYorkshire are you able to reproduce this with the latest development branch? I can't, with any of those 3 approaches!

EDIT: have a report from Az saying he can't reproduce it with latest development (as of the last couple of days).

Contributor

crabmusket commented Mar 1, 2015

@SteveYorkshire are you able to reproduce this with the latest development branch? I can't, with any of those 3 approaches!

EDIT: have a report from Az saying he can't reproduce it with latest development (as of the last couple of days).

@SteveYorkshire

This comment has been minimized.

Show comment
Hide comment
@SteveYorkshire

SteveYorkshire Mar 2, 2015

It's an issue in 3.6.3, I don't use the devhead because I can never remember how github works ;)

SteveYorkshire commented Mar 2, 2015

It's an issue in 3.6.3, I don't use the devhead because I can never remember how github works ;)

@SteveYorkshire

This comment has been minimized.

Show comment
Hide comment
@SteveYorkshire

SteveYorkshire Mar 7, 2015

Az reminded me that I can actually download the dev branch, so after testing, I am no longer seeing the issue in development. Looks like just 3.6.3 master. Closing this issue.

SteveYorkshire commented Mar 7, 2015

Az reminded me that I can actually download the dev branch, so after testing, I am no longer seeing the issue in development. Looks like just 3.6.3 master. Closing this issue.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Mar 7, 2015

Contributor

Cool. Slightly worrying, but I won't look a gift horse in the mouth.

Contributor

crabmusket commented Mar 7, 2015

Cool. Slightly worrying, but I won't look a gift horse in the mouth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment