New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define TORQUE_RELEASE doesnt get defined for release builds #1191

Closed
adambeer opened this Issue Feb 13, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@adambeer
Contributor

adambeer commented Feb 13, 2015

When browsing through the torqueConfig.h, I noticed that TORQUE_RELEASE wasn't defined when it was a release build but TORQUE_DEBUG would define properly.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 13, 2015

Contributor

I'm pretty sure TORQUE_RELEASE is intended to be enabled manually when you actually make a release, not just when you make a release build, maybe? Or possibly I'm thinking of TORQUE_SHIPPING.

Contributor

crabmusket commented Feb 13, 2015

I'm pretty sure TORQUE_RELEASE is intended to be enabled manually when you actually make a release, not just when you make a release build, maybe? Or possibly I'm thinking of TORQUE_SHIPPING.

@crabmusket crabmusket added the Defect label Feb 13, 2015

@adambeer

This comment has been minimized.

Show comment
Hide comment
@adambeer

adambeer Feb 13, 2015

Contributor

Yea the manual one is TORQUE_SHIPPING.

Contributor

adambeer commented Feb 13, 2015

Yea the manual one is TORQUE_SHIPPING.

@crabmusket crabmusket added this to the 3.7 milestone Feb 19, 2015

@crabmusket crabmusket added Bug and removed Defect labels Feb 19, 2015

@crabmusket crabmusket closed this Feb 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment