Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayObject Sort - Desc Parameter is inverted #120

Closed
DavidWyand-GG opened this issue Nov 8, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@DavidWyand-GG
Copy link
Member

commented Nov 8, 2012

Originally from THREED-3178

Source: http://www.garagegames.com/community/forums/viewthread/129494

Hi,

In ArrayObject, it is said:
@param descending optional True for descending sort, false for ascending sort\n

If you call ArrayObj.Sort(True) which should be descending (highest value to lowest) you get the opposite.

How to reproduce:
Construct array object with 3 item which value are 1,2,3 and try the sort function

Fix: Change the documentation to the correct description

@ghost ghost assigned DavidWyand-GG Nov 8, 2012

DavidWyand-GG added a commit that referenced this issue Nov 8, 2012

Merge pull request #121 from DavidWyand-GG/issue120-InvertedArrayObje…
…ctSort

Fix for Issue #120 for Inverted ArrayObject Sort
@DavidWyand-GG

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2012

Fixed in development branch.

@DavidWyand-GG

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2012

Original notes from Chris:

FIX - Fix backwards comment/functionality in ArrayObject sort functions (true=ascending, false=descending) (THREED-3178)

Dwarf-King pushed a commit to Dwarf-King/Torque3D that referenced this issue Apr 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.