Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSForestItemData only loading materials on client #157

Open
DavidWyand-GG opened this issue Nov 26, 2012 · 0 comments
Open

TSForestItemData only loading materials on client #157

DavidWyand-GG opened this issue Nov 26, 2012 · 0 comments
Assignees
Labels

Comments

@DavidWyand-GG
Copy link
Member

@DavidWyand-GG DavidWyand-GG commented Nov 26, 2012

Issue #155 was a fix for creating billboards on a dedicated server. This came about because TSForestItemData::_getShapeInstance() is creating a shape instance and always loading the materials. While issue #155 is a good fix, it may be able to be better.

Normally when a shape instance is created the materials are only loaded on the client. TSForestItemData::_getShapeInstance() goes against this and creates the materials regardless of being on the client or server. It appears to do this so it can check if it needs to add the wind effect to the shape.

However, the wind effect should be a client side only effect and I don't believe it needs to be checked on the server. This ticket exists to look into not checking the materials on the server side, and therefore passing in isClient() into the shape creation's loadMaterials flag.

@ghost ghost assigned DavidWyand-GG Nov 26, 2012
@crabmusket crabmusket added this to the 3.7 milestone Oct 7, 2014
@crabmusket crabmusket removed this from the 3.7 milestone Jan 28, 2015
@crabmusket crabmusket added this to the 3.8 milestone Jan 28, 2015
@crabmusket crabmusket added this to the 3.8 milestone Jan 28, 2015
@crabmusket crabmusket removed this from the 3.7 milestone Jan 28, 2015
@crabmusket crabmusket removed this from the 3.8 milestone Jun 24, 2015
@crabmusket crabmusket removed this from the 3.8 milestone Jun 24, 2015
Azaezel pushed a commit to Azaezel/Torque3D that referenced this issue May 17, 2020
show/hide children automagically for simgroups via inspector
lukaspj pushed a commit to lukaspj/Torque3D-Old that referenced this issue Oct 2, 2020
show/hide children automagically for simgroups via inspector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants