New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens flare effect rendering over objects #905

Closed
chieling opened this Issue Nov 6, 2014 · 15 comments

Comments

Projects
None yet
4 participants
@chieling

chieling commented Nov 6, 2014

untitled

This is a point of light behind a sail (TSStatic) of a ship. This isn't right behind it, its actually quite a ways off from the TSStatic

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 6, 2014

Contributor

It's called subsurface scattering? :P

Contributor

crabmusket commented Nov 6, 2014

It's called subsurface scattering? :P

@crabmusket crabmusket added the Bug label Nov 6, 2014

@crabmusket crabmusket added this to the 3.7 milestone Nov 6, 2014

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Nov 6, 2014

its called "it shouldn't be coming though a TStatic"

On Wed, Nov 5, 2014 at 10:23 PM, Daniel Buckmaster <notifications@github.com

wrote:

It's called subsurface scattering? :P


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

chieling commented Nov 6, 2014

its called "it shouldn't be coming though a TStatic"

On Wed, Nov 5, 2014 at 10:23 PM, Daniel Buckmaster <notifications@github.com

wrote:

It's called subsurface scattering? :P


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

@andr3wmac

This comment has been minimized.

Show comment
Hide comment
@andr3wmac

andr3wmac Nov 6, 2014

Contributor

This shouldn't be happening, lights are depth tested. I'd like to see your material settings for the flag material. I would expect the problem to be in the transparency settings. The material may not be writing to the depth buffer, check: Transparent Z-Write.

Contributor

andr3wmac commented Nov 6, 2014

This shouldn't be happening, lights are depth tested. I'd like to see your material settings for the flag material. I would expect the problem to be in the transparency settings. The material may not be writing to the depth buffer, check: Transparent Z-Write.

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Nov 6, 2014

Daniel called it " lensFlare effect"...?

On Thu, Nov 6, 2014 at 9:16 AM, Andrew Mac notifications@github.com wrote:

This shouldn't be happening, lights are depth tested. I'd like to see your
material settings for the material. I would expect the problem to be in the
transparency settings. The material may not be writing to the depth buffer,
check: Transparent Z-Write.


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

chieling commented Nov 6, 2014

Daniel called it " lensFlare effect"...?

On Thu, Nov 6, 2014 at 9:16 AM, Andrew Mac notifications@github.com wrote:

This shouldn't be happening, lights are depth tested. I'd like to see your
material settings for the material. I would expect the problem to be in the
transparency settings. The material may not be writing to the depth buffer,
check: Transparent Z-Write.


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

@andr3wmac

This comment has been minimized.

Show comment
Hide comment
@andr3wmac

andr3wmac Nov 6, 2014

Contributor

Could be. I didn't think it looked like a lens flare at first, but perhaps it is. Disable lens flare on the light and see if it goes away. If it doesn't go away, can you paste in the script for the material you're using on that flag?

Contributor

andr3wmac commented Nov 6, 2014

Could be. I didn't think it looked like a lens flare at first, but perhaps it is. Disable lens flare on the light and see if it goes away. If it doesn't go away, can you paste in the script for the material you're using on that flag?

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Nov 6, 2014

This is what i got from him:
had to switch off some of the flare lights , here ---> datablock
LightFlareData( LightFlareExample2 )

this would be a feature for the editor, so we can make or set the
lightflare in a editor. Otherwise it is just a datablock, can be also
edited in datablock editor, or from hand in script, like i did. But a
special editor for lightflare effects, would be a plus for noobs of the
engine.

On Thu, Nov 6, 2014 at 11:27 AM, Andrew Mac notifications@github.com
wrote:

Could be. I didn't think it looked like a lens flare at first, but perhaps
it is. Disable lens flare on the light and see if it goes away. If it
doesn't go away, can you paste in the script for the material you're using
on that flag?


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

chieling commented Nov 6, 2014

This is what i got from him:
had to switch off some of the flare lights , here ---> datablock
LightFlareData( LightFlareExample2 )

this would be a feature for the editor, so we can make or set the
lightflare in a editor. Otherwise it is just a datablock, can be also
edited in datablock editor, or from hand in script, like i did. But a
special editor for lightflare effects, would be a plus for noobs of the
engine.

On Thu, Nov 6, 2014 at 11:27 AM, Andrew Mac notifications@github.com
wrote:

Could be. I didn't think it looked like a lens flare at first, but perhaps
it is. Disable lens flare on the light and see if it goes away. If it
doesn't go away, can you paste in the script for the material you're using
on that flag?


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

@andr3wmac

This comment has been minimized.

Show comment
Hide comment
@andr3wmac

andr3wmac Nov 6, 2014

Contributor

I'm still unclear on whether or not it was a lens flare problem? Can you confirm with a Yes/No whether or not switching off the lens flare effects resolved your issues? Where Yes would be it resolved it, and No would mean it didn't.

Contributor

andr3wmac commented Nov 6, 2014

I'm still unclear on whether or not it was a lens flare problem? Can you confirm with a Yes/No whether or not switching off the lens flare effects resolved your issues? Where Yes would be it resolved it, and No would mean it didn't.

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Nov 6, 2014

yes, switching off lens flare in the datablock fixed it

On Thu, Nov 6, 2014 at 11:36 AM, Andrew Mac notifications@github.com
wrote:

I'm still unclear on whether or not it was a lens flare problem? Can you
confirm with a Yes/No whether or not switching off the lens flare effects
resolved your issues?


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

chieling commented Nov 6, 2014

yes, switching off lens flare in the datablock fixed it

On Thu, Nov 6, 2014 at 11:36 AM, Andrew Mac notifications@github.com
wrote:

I'm still unclear on whether or not it was a lens flare problem? Can you
confirm with a Yes/No whether or not switching off the lens flare effects
resolved your issues?


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

@andr3wmac

This comment has been minimized.

Show comment
Hide comment
@andr3wmac

andr3wmac Nov 6, 2014

Contributor

Okay, lens flare is unrelated to lighting. I know that might sound crazy, but it's an on-screen effect added after the fact and has it's own methods and apparently bugs as well.

Should probably close this and make a new issue about the specific problem (now that you know what it is) and/or suggested improvements to the lens flare system.

To summarize: issue is actually lens flare effect rendering over objects, not light bleeding through them.

Contributor

andr3wmac commented Nov 6, 2014

Okay, lens flare is unrelated to lighting. I know that might sound crazy, but it's an on-screen effect added after the fact and has it's own methods and apparently bugs as well.

Should probably close this and make a new issue about the specific problem (now that you know what it is) and/or suggested improvements to the lens flare system.

To summarize: issue is actually lens flare effect rendering over objects, not light bleeding through them.

@chieling chieling changed the title from Point of light bleed through TSStatics to Lens flare effect rendering over objects Nov 6, 2014

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Nov 6, 2014

renamed this since this whole chat I FELT was still valid to help with any fixes.

chieling commented Nov 6, 2014

renamed this since this whole chat I FELT was still valid to help with any fixes.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 6, 2014

Contributor

Yep, that's fine. Interesting problem. Does the sail have any sort of collision? I don't remember how lens flares are tested.

Contributor

crabmusket commented Nov 6, 2014

Yep, that's fine. Interesting problem. Does the sail have any sort of collision? I don't remember how lens flares are tested.

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Nov 6, 2014

the whole boat is 1 TStatic w colision

On Thu, Nov 6, 2014 at 4:42 PM, Daniel Buckmaster notifications@github.com
wrote:

Yep, that's fine. Interesting problem. Does the sail have any sort of
collision? I don't remember how lens flares are tested.


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

chieling commented Nov 6, 2014

the whole boat is 1 TStatic w colision

On Thu, Nov 6, 2014 at 4:42 PM, Daniel Buckmaster notifications@github.com
wrote:

Yep, that's fine. Interesting problem. Does the sail have any sort of
collision? I don't remember how lens flares are tested.


Reply to this email directly or view it on GitHub
#905 (comment)
.

Paul Yoskowitz
[image: http://]about.me/paulyoskowitz
http://about.me/paulyoskowitz?promo=email_sig

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 7, 2014

Contributor

See also #764

Contributor

crabmusket commented Nov 7, 2014

See also #764

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Dec 23, 2014

Contributor

Improve sun flare occlusion #1068

Contributor

LuisAntonRebollo commented Dec 23, 2014

Improve sun flare occlusion #1068

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jan 28, 2015

Contributor

Closed in favour of #1068.

Contributor

crabmusket commented Jan 28, 2015

Closed in favour of #1068.

@crabmusket crabmusket closed this Jan 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment