New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable MixedParticleRendering warning. #916

Closed
LuisAntonRebollo opened this Issue Nov 7, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@LuisAntonRebollo
Contributor

LuisAntonRebollo commented Nov 7, 2014

renderInstance\renderParticleMgr.cpp(499): warning C4553: '==' : operator has no effect; did you intend '='?

else
{
    AssertWarn(false, "No edge texture target defined, if you want to use mixed particle"
    "rendering, then make sure that the EdgeDetectPostEffect is enabled.");
    ri->systemState == PSS_AwaitingHighResDraw; // <<< this line
    return;
}

See the code here

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 7, 2014

Contributor

@LuisAntonRebollo feel free to label and milestone your own issues. @lukaspj this one is for you I think!

Contributor

crabmusket commented Nov 7, 2014

@LuisAntonRebollo feel free to label and milestone your own issues. @lukaspj this one is for you I think!

@crabmusket crabmusket added this to the 3.7 milestone Nov 7, 2014

@crabmusket crabmusket added the Bug label Nov 7, 2014

@lukaspj

This comment has been minimized.

Show comment
Hide comment
@lukaspj

lukaspj Nov 8, 2014

Contributor

Ahh thats what az meant...

Anyways I think I have to rethink that assert completely, AssertWarn doesn't make sense if you get a warn every frame. Think I'll have to change it to a fatal.

Contributor

lukaspj commented Nov 8, 2014

Ahh thats what az meant...

Anyways I think I have to rethink that assert completely, AssertWarn doesn't make sense if you get a warn every frame. Think I'll have to change it to a fatal.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 8, 2014

Contributor

Having a warn each frame doesn't seem good, but shouldn't there be an 'I don't want to use mixed particle rendering' option that doesn't cause a fatal assert? :P

Contributor

crabmusket commented Nov 8, 2014

Having a warn each frame doesn't seem good, but shouldn't there be an 'I don't want to use mixed particle rendering' option that doesn't cause a fatal assert? :P

@lukaspj

This comment has been minimized.

Show comment
Hide comment
@lukaspj

lukaspj Nov 8, 2014

Contributor

Yes, it's called setting "highresonly" to true :P

Contributor

lukaspj commented Nov 8, 2014

Yes, it's called setting "highresonly" to true :P

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 8, 2014

Contributor

Yeah okay then :P. I was hoping for a game config solution but I guess this will do.

Contributor

crabmusket commented Nov 8, 2014

Yeah okay then :P. I was hoping for a game config solution but I guess this will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment