New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lighting errors when all lights are disabled. #1006

Merged
merged 2 commits into from Mar 1, 2015

Conversation

Projects
None yet
3 participants
@LuisAntonRebollo
Contributor

LuisAntonRebollo commented Dec 3, 2014

When scene has zero lights sources actives, last RenderTexTargetBinManagerrender target are used for render. This cause render artifatcs.

screenshot 2014-12-03 23 48 13

Thx @Lopuska for the fix :)

For replicate:

  • Remove or hidde all light sources on editor.

@crabmusket crabmusket added the Bug label Dec 4, 2014

@crabmusket crabmusket added this to the 3.7 milestone Dec 4, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 7, 2014

Contributor

It seems to cause a crash for me here in a debug build, using DirectX in Windows 7. EDIT: might be just me being silly. Will check again soon.

Contributor

crabmusket commented Dec 7, 2014

It seems to cause a crash for me here in a debug build, using DirectX in Windows 7. EDIT: might be just me being silly. Will check again soon.

@Lopuska

This comment has been minimized.

Show comment
Hide comment
@Lopuska

Lopuska Dec 10, 2014

Member

I sent the fix to Luis! I forgot to pass him another change : )
Now it should to work.

Member

Lopuska commented Dec 10, 2014

I sent the fix to Luis! I forgot to pass him another change : )
Now it should to work.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 21, 2015

Contributor

Um, I don't think @LuisAntonRebollo made another change :P. Unless the first commit was rebased. Will test again sometime today.

Contributor

crabmusket commented Feb 21, 2015

Um, I don't think @LuisAntonRebollo made another change :P. Unless the first commit was rebased. Will test again sometime today.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Mar 1, 2015

Contributor

Ok, looks good now :)

Contributor

crabmusket commented Mar 1, 2015

Ok, looks good now :)

crabmusket added a commit that referenced this pull request Mar 1, 2015

Merge pull request #1006 from BeamNG/fix_lighting_with_zero_lights
Fix lighting errors when all lights are disabled.

@crabmusket crabmusket merged commit baf594a into GarageGames:development Mar 1, 2015

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment