New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where console stack values were getting overwritten #1026

Merged
merged 2 commits into from Dec 21, 2014

Conversation

Projects
None yet
3 participants
@jamesu
Contributor

jamesu commented Dec 10, 2014

Fixes issue #976 by deferring the stack reset until the next root execution of script. Also adds code to ensure the initial string stack buffer is blank, preventing an issue with the terminal debugger code execution.

@@ -796,6 +796,7 @@ ExprEvalState::ExprEvalState()
currentVariable = NULL;
mStackDepth = 0;
stack.reserve( 64 );
mShouldReset = false;

This comment has been minimized.

@bpay

bpay Dec 10, 2014

Contributor

Should mResetLocked be initialized here as well?

@bpay

bpay Dec 10, 2014

Contributor

Should mResetLocked be initialized here as well?

This comment has been minimized.

@jamesu

jamesu Dec 10, 2014

Contributor

Yes, must have missed that. Whoopsie

@jamesu

jamesu Dec 10, 2014

Contributor

Yes, must have missed that. Whoopsie

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 10, 2014

Contributor

Awesome, thanks! Will verify tonight.

Contributor

crabmusket commented Dec 10, 2014

Awesome, thanks! Will verify tonight.

@crabmusket crabmusket added the Bug label Dec 10, 2014

@crabmusket crabmusket added this to the 3.7 milestone Dec 10, 2014

crabmusket added a commit that referenced this pull request Dec 21, 2014

Merge pull request #1026 from jamesu/fix_console_stack
Fix issue where console stack values were getting overwritten

@crabmusket crabmusket merged commit 7916ff3 into GarageGames:development Dec 21, 2014

1 check passed

default Merged build finished.
Details

Azaezel added a commit to Azaezel/Torque3D that referenced this pull request Jan 28, 2015

@jamesu jamesu deleted the jamesu:fix_console_stack branch Jul 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment