New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumetric Fog Resource by Richard Marrevee. #1030

Closed
wants to merge 7 commits into
base: development
from

Conversation

Projects
None yet
6 participants
@Winterleaf
Contributor

Winterleaf commented Dec 10, 2014

Updated by Vince Gee to fix bug of not deleting shapeinstance ptr and the bug related to going in and out of editor tools.

Winterleaf added some commits Dec 10, 2014

Volumetric Fog Resource by Richard Marrevee. Updated by Vince Gee to …
…fix bug of not deleting shapeinstance ptr and the bug related to going in and out of tools.

@crabmusket crabmusket added this to the 3.7 milestone Dec 10, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 10, 2014

Contributor

Hero! I forgot about this. Thanks for the contribution, and thanks @RichardsGameStudio!

It seems there are some unrelated(?) changes included. Also wow, there's a lot of additional art. I'd prefer to keep the changes to Empty as minimal as possible - the shaders are necessary but can we remove the art?

Contributor

crabmusket commented Dec 10, 2014

Hero! I forgot about this. Thanks for the contribution, and thanks @RichardsGameStudio!

It seems there are some unrelated(?) changes included. Also wow, there's a lot of additional art. I'd prefer to keep the changes to Empty as minimal as possible - the shaders are necessary but can we remove the art?

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Dec 10, 2014

Contributor

Yeah,

It’s a pretty awesome resource,

Contributor

Winterleaf commented Dec 10, 2014

Yeah,

It’s a pretty awesome resource,

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Dec 10, 2014

the fog uses a shape to make the fog itself. I think the DTS or the DEA could be taken out of the environment folder but if u remove both then youre taking away "fog shapes"

chieling commented Dec 10, 2014

the fog uses a shape to make the fog itself. I think the DTS or the DEA could be taken out of the environment folder but if u remove both then youre taking away "fog shapes"

@dottools

This comment has been minimized.

Show comment
Hide comment
@dottools

dottools Dec 10, 2014

What's with all the unrelated changes?

dottools commented Dec 10, 2014

What's with all the unrelated changes?

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Dec 10, 2014

Contributor

I always remove the tab’s from the files I touch.

Contributor

Winterleaf commented Dec 10, 2014

I always remove the tab’s from the files I touch.

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Dec 10, 2014

Contributor

oh thats freaking nice.... I must have had all solution in stead of file open for the find and replace....

On the plus side, all the tabs are out of the source code.....

Contributor

Winterleaf commented Dec 10, 2014

oh thats freaking nice.... I must have had all solution in stead of file open for the find and replace....

On the plus side, all the tabs are out of the source code.....

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Dec 10, 2014

Contributor

Oh, I did the find and replace right, I think you are looking at all the shapes provided for the fog.

Contributor

Winterleaf commented Dec 10, 2014

Oh, I did the find and replace right, I think you are looking at all the shapes provided for the fog.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 11, 2014

Contributor

Yeah, I'm not super happy with just adding a bunch of fog shapes. Is there no way we could make this work with, for example, the convex editor? Failing that, I think it'd be a good idea to just provide a single fog shape as an example for users, who can then make their own to suit their needs.

@Winterleaf feel free to make another PR removing tabs.

Contributor

crabmusket commented Dec 11, 2014

Yeah, I'm not super happy with just adding a bunch of fog shapes. Is there no way we could make this work with, for example, the convex editor? Failing that, I think it'd be a good idea to just provide a single fog shape as an example for users, who can then make their own to suit their needs.

@Winterleaf feel free to make another PR removing tabs.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Dec 11, 2014

Contributor

We need a OpenGL version for accept this PR.

@Lopuska, are working on port.

Contributor

LuisAntonRebollo commented Dec 11, 2014

We need a OpenGL version for accept this PR.

@Lopuska, are working on port.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 11, 2014

Contributor

👍

Contributor

crabmusket commented Dec 11, 2014

👍

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Dec 11, 2014

"We need a OpenGL version for accept this PR."
What kind of timeframe are we looking at?

chieling commented Dec 11, 2014

"We need a OpenGL version for accept this PR."
What kind of timeframe are we looking at?

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 11, 2014

Contributor

Sounds like they've got this covered.

Contributor

crabmusket commented Dec 11, 2014

Sounds like they've got this covered.

@chieling

This comment has been minimized.

Show comment
Hide comment
@chieling

chieling Dec 11, 2014

Wasn't doubting that at all Daniel, I have complete confidence in their ability to complete it. However, I also know they already have a hella plateful with other OGL and DX tasks. This was nothing more than a question of timing and if having it for T3D 3.7 was the target still.

chieling commented Dec 11, 2014

Wasn't doubting that at all Daniel, I have complete confidence in their ability to complete it. However, I also know they already have a hella plateful with other OGL and DX tasks. This was nothing more than a question of timing and if having it for T3D 3.7 was the target still.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 11, 2014

Contributor

Got you, thanks :).

Contributor

crabmusket commented Dec 11, 2014

Got you, thanks :).

@RichardsGameStudio

This comment has been minimized.

Show comment
Hide comment
@RichardsGameStudio

RichardsGameStudio Dec 11, 2014

Contributor

Sorry guys, caught by a flu. The shapes I've added are just examples on how the fog can be used, so they can be left out if you like. @Winterleaf: thanks for adding this as a PR.

Contributor

RichardsGameStudio commented Dec 11, 2014

Sorry guys, caught by a flu. The shapes I've added are just examples on how the fog can be used, so they can be left out if you like. @Winterleaf: thanks for adding this as a PR.

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Dec 11, 2014

Contributor

@richard Marrevee,

I had to fix a couple bugs in your code, not sure if your using it in your game buy you might want to check them out.

Contributor

Winterleaf commented Dec 11, 2014

@richard Marrevee,

I had to fix a couple bugs in your code, not sure if your using it in your game buy you might want to check them out.

@Winterleaf Winterleaf closed this Dec 16, 2014

@Winterleaf Winterleaf deleted the Winterleaf:volumetricfog21 branch Dec 16, 2014

@Winterleaf Winterleaf referenced this pull request Dec 21, 2014

Closed

Volumetric fog redo #1059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment