New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memfixes #1035

Merged
merged 15 commits into from Jan 25, 2015

Conversation

Projects
None yet
4 participants
@bpay
Contributor

bpay commented Dec 12, 2014

Fixes for issues flagged by Dr.Memory and the MSVC static analysis tool, along with a few misc code hygiene improvements

@dottools

This comment has been minimized.

Show comment
Hide comment
@dottools

dottools Dec 12, 2014

Interesting findings. Will definitely have a thorough look through these changes. I'm surprised the dFree() vs delete was spotted, I would have never seen that myself.

dottools commented Dec 12, 2014

Interesting findings. Will definitely have a thorough look through these changes. I'm surprised the dFree() vs delete was spotted, I would have never seen that myself.

@crabmusket crabmusket added the Defect label Dec 12, 2014

@crabmusket crabmusket added this to the 3.7 milestone Dec 12, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 12, 2014

Contributor

Awesome, I'll have a look at this tonight :). Thanks!

Contributor

crabmusket commented Dec 12, 2014

Awesome, I'll have a look at this tonight :). Thanks!

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Dec 12, 2014

Contributor

Very good work 👍

Contributor

LuisAntonRebollo commented Dec 12, 2014

Very good work 👍

Show outdated Hide outdated Engine/source/main/main.cpp Outdated
@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Jan 25, 2015

Contributor

TEST ON CI SERVER

Contributor

LuisAntonRebollo commented Jan 25, 2015

TEST ON CI SERVER

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Jan 25, 2015

Contributor

Thx :)

Contributor

LuisAntonRebollo commented Jan 25, 2015

Thx :)

LuisAntonRebollo added a commit that referenced this pull request Jan 25, 2015

@LuisAntonRebollo LuisAntonRebollo merged commit 6492028 into GarageGames:development Jan 25, 2015

1 check was pending

default Merge build triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment