New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS2012 support to projectgenerator #1049

Merged
merged 1 commit into from Mar 14, 2015

Conversation

Projects
None yet
4 participants
@cornytrace
Contributor

cornytrace commented Dec 13, 2014

Files are essentially just copied from the 2010 version with slight
tweaks, works without any warnings or errors.
It prevents having to do the annoying conversion from the VS2010 version every time you regenerate.
Is additional work on projectgenerator even wanted, seeing as there is also the competing cmake build system?

Add VS2012 support
Files are essentially just copied from the 2010 version with slight
tweaks, works without any warnings or errors.
@dottools

This comment has been minimized.

Show comment
Hide comment
@dottools

dottools Dec 14, 2014

Thank you for improving projectGenerator. Prefer it over CMake myself so please by all means, keep contributing projectGenerator changes. :)

dottools commented Dec 14, 2014

Thank you for improving projectGenerator. Prefer it over CMake myself so please by all means, keep contributing projectGenerator changes. :)

@crabmusket crabmusket added this to the 3.7 milestone Dec 14, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 14, 2014

Contributor

Thanks for the contribution! Before we can accept your PR, we need you to create an account at http://garagegames.com and sign the OSA in your profile. Then we have to wait for GG to tell us you've signed it ;P.

Contributor

crabmusket commented Dec 14, 2014

Thanks for the contribution! Before we can accept your PR, we need you to create an account at http://garagegames.com and sign the OSA in your profile. Then we have to wait for GG to tell us you've signed it ;P.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Mar 7, 2015

Contributor

@cornytrace , have you signed OSA?

We need your GG account name for verification.

Contributor

LuisAntonRebollo commented Mar 7, 2015

@cornytrace , have you signed OSA?

We need your GG account name for verification.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Mar 14, 2015

Contributor

I get this error: RC : fatal error RC1110: could not open Torque.rc

I think we need to copy some files to templates/???/buildFiles/VisualStudio 2012/projects

Edited: Easy fix... we can merge.

Contributor

LuisAntonRebollo commented Mar 14, 2015

I get this error: RC : fatal error RC1110: could not open Torque.rc

I think we need to copy some files to templates/???/buildFiles/VisualStudio 2012/projects

Edited: Easy fix... we can merge.

LuisAntonRebollo added a commit that referenced this pull request Mar 14, 2015

Merge pull request #1049 from cornytrace/VS2012-Support
Add VS2012 support to projectgenerator

@LuisAntonRebollo LuisAntonRebollo merged commit c73355b into GarageGames:development Mar 14, 2015

1 check was pending

default Merge build triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment