New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mipmap support on OpenGL cubemap #1056

Merged
merged 6 commits into from Dec 27, 2014

Conversation

Projects
None yet
3 participants
@Lopuska
Member

Lopuska commented Dec 15, 2014

just need to test :)

@dottools

View changes

Show outdated Hide outdated Engine/source/gfx/gl/gfxGLCubemap.cpp

@Azaezel Azaezel referenced this pull request Dec 18, 2014

Closed

ReflectCubeFeat review #4

@LuisAntonRebollo LuisAntonRebollo added this to the 3.7 milestone Dec 18, 2014

@LuisAntonRebollo LuisAntonRebollo self-assigned this Dec 18, 2014

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Dec 25, 2014

Contributor

Thx :)

After check code... i see we need to add mipmaps support for void GFXGLCubemap::fillCubeTextures(GFXTexHandle* faces) and void GFXGLCubemap::initDynamic(U32 texSize, GFXFormat faceFormat)

Contributor

LuisAntonRebollo commented Dec 25, 2014

Thx :)

After check code... i see we need to add mipmaps support for void GFXGLCubemap::fillCubeTextures(GFXTexHandle* faces) and void GFXGLCubemap::initDynamic(U32 texSize, GFXFormat faceFormat)

@LuisAntonRebollo LuisAntonRebollo changed the title from mipmap support on DDS for openGL cubemap to mipmap support on OpenGL cubemap Dec 26, 2014

LuisAntonRebollo added a commit that referenced this pull request Dec 27, 2014

Merge pull request #1056 from Lopuska/patch-12
mipmap support on OpenGL cubemap

@LuisAntonRebollo LuisAntonRebollo merged commit 39bd99a into GarageGames:development Dec 27, 2014

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment