New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake fixes #1064

Merged
merged 4 commits into from Dec 27, 2014

Conversation

Projects
None yet
3 participants
@bpay
Contributor

bpay commented Dec 17, 2014

No description provided.

bpay added some commits Dec 2, 2014

Fix CMP0043 cmake warning when using cmake 3.0.2
COMPILE_DEFINITIONS_CONFIG has been deprecated, use generator expressions
with plain COMPILE_DEFINITIONS instead (available since 2.8.10)
Fix broken cmake macro
Only the first config in the list was being seen

@crabmusket crabmusket added the Defect label Dec 17, 2014

@crabmusket crabmusket added this to the 3.7 milestone Dec 17, 2014

@@ -596,6 +596,17 @@ if(UNIX)
addInclude("/usr/include/freetype2")
endif()
if(MSVC)
# Match projectGenerator naming for executables

This comment has been minimized.

@crabmusket

crabmusket Dec 17, 2014

Contributor

👍!

@crabmusket

crabmusket Dec 17, 2014

Contributor

👍!

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 17, 2014

Contributor

Thanks! Looks good.

Contributor

crabmusket commented Dec 17, 2014

Thanks! Looks good.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 21, 2014

Contributor

Fixes #816.

Contributor

crabmusket commented Dec 21, 2014

Fixes #816.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Dec 27, 2014

Contributor

Tested, very good work 👍

Fixes VS2013 intellisense :)

Contributor

LuisAntonRebollo commented Dec 27, 2014

Tested, very good work 👍

Fixes VS2013 intellisense :)

LuisAntonRebollo added a commit that referenced this pull request Dec 27, 2014

@LuisAntonRebollo LuisAntonRebollo merged commit f4b3d1e into GarageGames:development Dec 27, 2014

1 check was pending

default Merge build triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment