New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winTime month fix #1065

Merged
merged 1 commit into from Dec 21, 2014

Conversation

Projects
None yet
2 participants
@rextimmy
Contributor

rextimmy commented Dec 18, 2014

Windows SYSTEMTIME stores month 1-12 while T3D LocalTime stores month 0-11. This obviously causes problems with GetDateFormat used in the function Platform::localTimeToString( const LocalTime &lt ) in winTime.cpp. Especially in December ;-)

@crabmusket crabmusket added the Bug label Dec 18, 2014

@crabmusket crabmusket added this to the 3.7 milestone Dec 18, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 18, 2014

Contributor

Good catch :).

Contributor

crabmusket commented Dec 18, 2014

Good catch :).

@rextimmy

This comment has been minimized.

Show comment
Hide comment
@rextimmy

rextimmy Dec 18, 2014

Contributor

I only noticed because that AssertWarn on line 90 was getting triggered all of a sudden.

Contributor

rextimmy commented Dec 18, 2014

I only noticed because that AssertWarn on line 90 was getting triggered all of a sudden.

crabmusket added a commit that referenced this pull request Dec 21, 2014

@crabmusket crabmusket merged commit 949251b into GarageGames:development Dec 21, 2014

@rextimmy rextimmy deleted the rextimmy:windows_date_fix branch Feb 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment