New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest wind emitter #1124

Merged
merged 2 commits into from Jan 26, 2015

Conversation

Projects
None yet
3 participants
@crabmusket
Contributor

crabmusket commented Jan 25, 2015

Redo of #896 with cleanup.

Winterleaf and others added some commits Nov 4, 2014

Dev forest wind emitter improvement
So the problem is that when your inside the sphere it won't render so it might make someone
think that it's not working right.  So what I did was determine if the camera is inside the sphere.
If the camera is inside the sphere, then I find the distance from the center of the sphere to the camera
Round down and use that as the radius to draw the sphere.
That way if someone zooms in or out, their screen is still showing the sphere.
@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jan 25, 2015

Contributor

Works fine for me.

Contributor

Areloch commented Jan 25, 2015

Works fine for me.

@crabmusket crabmusket added this to the 3.7 milestone Jan 25, 2015

@crabmusket crabmusket added the Defect label Jan 25, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jan 26, 2015

Contributor

What does the effect actually look like? I haven't see it in action, just refactored Vince's code. How can you see the sphere if it intersects the camera location?

Contributor

crabmusket commented Jan 26, 2015

What does the effect actually look like? I haven't see it in action, just refactored Vince's code. How can you see the sphere if it intersects the camera location?

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jan 26, 2015

Contributor

It pretty much forces it to render as much as it can. You still see some clipping - I think due to issues with the near plane - but you can at least tell the circle still there and didn't inexplicably stop existing.

There's probably an even better way to do it for the future, but this should work well enough as a fix for the current method.

Contributor

Areloch commented Jan 26, 2015

It pretty much forces it to render as much as it can. You still see some clipping - I think due to issues with the near plane - but you can at least tell the circle still there and didn't inexplicably stop existing.

There's probably an even better way to do it for the future, but this should work well enough as a fix for the current method.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jan 26, 2015

Contributor

Double-sided sphere?

Contributor

crabmusket commented Jan 26, 2015

Double-sided sphere?

crabmusket added a commit that referenced this pull request Jan 26, 2015

Merge pull request #1124 from eightyeight/forest-wind-emitter
Forest wind emitter rendering improvement

@crabmusket crabmusket merged commit 70d2ec6 into GarageGames:development Jan 26, 2015

1 check passed

default Merged build finished.
Details

@crabmusket crabmusket deleted the crabmusket:forest-wind-emitter branch Jan 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment