New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More x64 fixes #1149

Closed
wants to merge 3 commits into
base: development
from

Conversation

Projects
None yet
3 participants
@LuisAntonRebollo
Contributor

LuisAntonRebollo commented Jan 31, 2015

See Issues on x64 builds #1144

@bpay

This comment has been minimized.

Show comment
Hide comment
@bpay

bpay Feb 5, 2015

Contributor

These type aliases look a lot like macros. Can they be lowercased? I know the rest of the numeric typedefs are not, but I think it's too late to fix those...plus, they have numbers embedded (S32, F32) in them which makes them a little less macro-like.

Contributor

bpay commented Feb 5, 2015

These type aliases look a lot like macros. Can they be lowercased? I know the rest of the numeric typedefs are not, but I think it's too late to fix those...plus, they have numbers embedded (S32, F32) in them which makes them a little less macro-like.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 5, 2015

Contributor

Typedefs are type-level macros ;).

Contributor

crabmusket commented Feb 5, 2015

Typedefs are type-level macros ;).

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Feb 7, 2015

Contributor

I only added SPTR and UPTR types, becouse some ppl commented to me that c++ types dont look consistent with T3D types.

I prefer to use c++ style types, but we cant change old types.

I'm going to separate fix and rename to diferent PRs.

Contributor

LuisAntonRebollo commented Feb 7, 2015

I only added SPTR and UPTR types, becouse some ppl commented to me that c++ types dont look consistent with T3D types.

I prefer to use c++ style types, but we cant change old types.

I'm going to separate fix and rename to diferent PRs.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Feb 7, 2015

Contributor

Continue discussion on #1162

Contributor

LuisAntonRebollo commented Feb 7, 2015

Continue discussion on #1162

@LuisAntonRebollo LuisAntonRebollo deleted the BeamNG:fix_x64 branch Feb 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment