New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include navigation and testing modules by default #1159

Merged
merged 5 commits into from Feb 14, 2015

Conversation

Projects
None yet
2 participants
@crabmusket
Contributor

crabmusket commented Feb 7, 2015

  • They are both useful and can easily be turned off.
  • Navigation being off by default causes problems with the navmesh editor, which is included by default, but nonfunctional unless the module is included.
  • Navigation can kind of be considered a stock feature.

The only problem is that I see no way to do something equivalent with the project generator. We could add includeModule to the Templates' default config files, but this won't show up in the manager UI when you create a new project.

@crabmusket crabmusket added the Defect label Feb 7, 2015

@crabmusket crabmusket added this to the 3.7 milestone Feb 7, 2015

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Feb 7, 2015

Contributor

Fixed compilation on Linux.

Contributor

LuisAntonRebollo commented Feb 7, 2015

Fixed compilation on Linux.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 7, 2015

Contributor

T_T thanks for that, I meant to come back and check it but then bedtime happened. Also it appears there's no way to do this in the project manager. I think. I will try to make that happen.

Contributor

crabmusket commented Feb 7, 2015

T_T thanks for that, I meant to come back and check it but then bedtime happened. Also it appears there's no way to do this in the project manager. I think. I will try to make that happen.

@crabmusket crabmusket changed the title from Default navigation module on in CMake to Make navigation and testing modules default to on in CMake Feb 8, 2015

@crabmusket crabmusket changed the title from Make navigation and testing modules default to on in CMake to Include navigation and testing modules by default Feb 8, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 8, 2015

Contributor

Project manager 2.2 will allow setting default modules for inclusion, so I think this is good to go.

Contributor

crabmusket commented Feb 8, 2015

Project manager 2.2 will allow setting default modules for inclusion, so I think this is good to go.

@crabmusket crabmusket added Final review and removed Final review labels Feb 8, 2015

crabmusket added a commit that referenced this pull request Feb 14, 2015

Merge pull request #1159 from GarageGames/navigation-default-on
Include navigation and testing modules by default

@crabmusket crabmusket merged commit 4762668 into development Feb 14, 2015

1 check passed

default Merged build finished.
Details

@crabmusket crabmusket deleted the navigation-default-on branch Feb 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment