New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS2008 again #1176

Merged
merged 1 commit into from Feb 10, 2015

Conversation

Projects
None yet
3 participants
@crabmusket
Contributor

crabmusket commented Feb 10, 2015

No description provided.

@crabmusket crabmusket added the Bug label Feb 10, 2015

@crabmusket crabmusket added this to the 3.7 milestone Feb 10, 2015

crabmusket added a commit that referenced this pull request Feb 10, 2015

@crabmusket crabmusket merged commit f26210f into development Feb 10, 2015

@crabmusket crabmusket deleted the fix-vs2008-again branch Feb 10, 2015

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu Feb 12, 2015

Contributor

How many people are using 2008 still anyway? Even we're using 2010.

Contributor

jamesu commented on d10afa2 Feb 12, 2015

How many people are using 2008 still anyway? Even we're using 2010.

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 12, 2015

Contributor

They seem to come out of the woodwork whenever we say 'C++11'.

Contributor

crabmusket replied Feb 12, 2015

They seem to come out of the woodwork whenever we say 'C++11'.

This comment has been minimized.

Show comment
Hide comment
@dottools

dottools Feb 12, 2015

/me slowly raises hand..

dottools replied Feb 12, 2015

/me slowly raises hand..

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 12, 2015

Contributor

@dottools I don't have a VS2008 installation. Would you be willing to investigate what it takes to get T3D to be compatible with VS2008 for this release? We don't want to break compatibility until 3.8, because we didn't announce anything ahead of time. But relying on the GG CI server to give me feedback on whether my commits work is a painful process :P.

Most of the problems seem to stem from a lack of <stdint.h>. Maybe we could put this somewhere in the source tree and include it only on VS2008, instead of trying to do my hacky workaround here.

Contributor

crabmusket replied Feb 12, 2015

@dottools I don't have a VS2008 installation. Would you be willing to investigate what it takes to get T3D to be compatible with VS2008 for this release? We don't want to break compatibility until 3.8, because we didn't announce anything ahead of time. But relying on the GG CI server to give me feedback on whether my commits work is a painful process :P.

Most of the problems seem to stem from a lack of <stdint.h>. Maybe we could put this somewhere in the source tree and include it only on VS2008, instead of trying to do my hacky workaround here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment