New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return the result value of scrollVisible #1196

Merged
merged 1 commit into from Feb 15, 2015

Conversation

Projects
None yet
4 participants
@brakhane
Contributor

brakhane commented Feb 14, 2015

The console function changed from void to bool, so we
should actually return the value.

Also, the missing return is an error in VS2013.

return the result value of scrollVisible
The console function changed from void to bool, so we
should actually return the value.

Also, the missing return is an error in VS2013.
@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Feb 14, 2015

Contributor

verified necessary for compiliation with the latest devhead.

Contributor

Azaezel commented Feb 14, 2015

verified necessary for compiliation with the latest devhead.

Areloch added a commit that referenced this pull request Feb 15, 2015

Merge pull request #1196 from brakhane/scrollVisible-missing-return
Confirmed that this is needed to compile and fixes the problem.

@Areloch Areloch merged commit a7740bc into GarageGames:development Feb 15, 2015

1 check passed

default Merged build finished.
Details

@crabmusket crabmusket added the Bug label Feb 15, 2015

@crabmusket crabmusket added this to the 3.7 milestone Feb 15, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 15, 2015

Contributor

Sorry, meant to do this last night then got sidetracked. Thanks :).

Contributor

crabmusket commented Feb 15, 2015

Sorry, meant to do this last night then got sidetracked. Thanks :).

@brakhane brakhane deleted the brakhane:scrollVisible-missing-return branch Feb 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment