New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NULL check in function findItemByName. #1199

Merged
merged 1 commit into from Feb 22, 2015

Conversation

Projects
None yet
2 participants
@antonyjones67
Contributor

antonyjones67 commented Feb 15, 2015

(cherry picked from commit adb2513a2461092486e00b5550bf57fb83d0ccac)

When items in the gui tree control are removed it does not resize the array because it can create a problem with the tree item id's. So it just NULL's out the element. This causes an access violation.

Added NULL check in function findItemByName.
(cherry picked from commit adb2513a2461092486e00b5550bf57fb83d0ccac)

@crabmusket crabmusket added this to the 3.7 milestone Feb 17, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 21, 2015

Contributor

Thanks for the PR! Note - in future, it's a good idea to make a separate branch off development for each PR, otherwise there will be pain.

Contributor

crabmusket commented Feb 21, 2015

Thanks for the PR! Note - in future, it's a good idea to make a separate branch off development for each PR, otherwise there will be pain.

crabmusket added a commit that referenced this pull request Feb 22, 2015

Merge pull request #1199 from antonyjones67/development
Added NULL check in function findItemByName.

@crabmusket crabmusket merged commit 686f8d0 into GarageGames:development Feb 22, 2015

1 check passed

default Merged build finished.
Details
@antonyjones67

This comment has been minimized.

Show comment
Hide comment
@antonyjones67

antonyjones67 Mar 14, 2015

Contributor

sorry i'll do better in the future. still learning this git hub thing :)

On 2/21/2015 3:53 PM, Daniel Buckmaster wrote:

Thanks for the PR! Testing now. Note - in future, it's a good idea to
make a separate branch off |development| for each PR, otherwise there
will be pain.


Reply to this email directly or view it on GitHub
#1199 (comment).

Contributor

antonyjones67 commented Mar 14, 2015

sorry i'll do better in the future. still learning this git hub thing :)

On 2/21/2015 3:53 PM, Daniel Buckmaster wrote:

Thanks for the PR! Testing now. Note - in future, it's a good idea to
make a separate branch off |development| for each PR, otherwise there
will be pain.


Reply to this email directly or view it on GitHub
#1199 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment