New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for minidump support #1200

Merged
merged 3 commits into from Feb 20, 2015

Conversation

Projects
None yet
2 participants
@adambeer
Contributor

adambeer commented Feb 15, 2015

This allows minidump support to compile and be setup correctly when the checkbox is checked. The VS lib templates were missing TORQUE_RELEASE in the preprocessor definitions which caused minidump support to not be enabled regardless of a checkbox or not.

@adambeer

This comment has been minimized.

Show comment
Hide comment
@adambeer

adambeer Feb 15, 2015

Contributor

This is in response to #1191 and #1192

Contributor

adambeer commented Feb 15, 2015

This is in response to #1191 and #1192

@crabmusket crabmusket added this to the 3.7 milestone Feb 19, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 19, 2015

Contributor

Do we need to do anything about the TORQUE_MINIDUMP define or is that one okay after all?

Contributor

crabmusket commented Feb 19, 2015

Do we need to do anything about the TORQUE_MINIDUMP define or is that one okay after all?

@adambeer

This comment has been minimized.

Show comment
Hide comment
@adambeer

adambeer Feb 20, 2015

Contributor

TORQUE_MINIDUMP is being set correctly, this fix is just for adding TORQUE_RELEASE for release builds which is required along side the MINIDUMP define, and also to get a file to compile when its included from the 2 defines.

Contributor

adambeer commented Feb 20, 2015

TORQUE_MINIDUMP is being set correctly, this fix is just for adding TORQUE_RELEASE for release builds which is required along side the MINIDUMP define, and also to get a file to compile when its included from the 2 defines.

crabmusket added a commit that referenced this pull request Feb 20, 2015

@crabmusket crabmusket merged commit 3ed6dfb into GarageGames:development Feb 20, 2015

1 check passed

default Merged build finished.
Details
@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 20, 2015

Contributor

Thanks for the fix!

Contributor

crabmusket commented Feb 20, 2015

Thanks for the fix!

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 25, 2015

Contributor

@adambeer could you sign the OSA agreement in your GG.com account? I should have checked before merging :).

Contributor

crabmusket commented Feb 25, 2015

@adambeer could you sign the OSA agreement in your GG.com account? I should have checked before merging :).

@adambeer

This comment has been minimized.

Show comment
Hide comment
@adambeer

adambeer Feb 25, 2015

Contributor

Done. I knew about this and probably should have done it before submitting ;)

Contributor

adambeer commented Feb 25, 2015

Done. I knew about this and probably should have done it before submitting ;)

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 25, 2015

Contributor

Thanks!

Contributor

crabmusket commented Feb 25, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment