New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues flagged by cppcheck #1214

Merged
merged 10 commits into from Mar 1, 2015

Conversation

Projects
None yet
3 participants
@bpay
Contributor

bpay commented Feb 20, 2015

Resolves #1152

Any ideas on 3205fea ?

mWindSpeed( 1.0f ),
mLastTime( 0 )
mCoverage( 0.5f ),
mWindSpeed( 1.0f )

This comment has been minimized.

@crabmusket

crabmusket Feb 21, 2015

Contributor

-Wreorder?

@crabmusket

crabmusket Feb 21, 2015

Contributor

-Wreorder?

This comment has been minimized.

@bpay

bpay Feb 21, 2015

Contributor

Yes, figured I would fix the order while I was there. Also makes it easier to see what was left uninintialized. Doing a full reorder pass would be nice, but I am not voluteering for that at the moment. Any takers? :)

@bpay

bpay Feb 21, 2015

Contributor

Yes, figured I would fix the order while I was there. Also makes it easier to see what was left uninintialized. Doing a full reorder pass would be nice, but I am not voluteering for that at the moment. Any takers? :)

This comment has been minimized.

@crabmusket

crabmusket Feb 21, 2015

Contributor

I'll do it after 3.7 :P #1150

@crabmusket

crabmusket Feb 21, 2015

Contributor

I'll do it after 3.7 :P #1150

@crabmusket crabmusket added this to the 3.7 milestone Feb 21, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Feb 21, 2015

Contributor

Want to stick this in 3.7 if we can.

Contributor

crabmusket commented Feb 21, 2015

Want to stick this in 3.7 if we can.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Mar 1, 2015

Contributor

Didn't see that commit - thanks! @everyone: speak now or forever hold your peace.

Contributor

crabmusket commented Mar 1, 2015

Didn't see that commit - thanks! @everyone: speak now or forever hold your peace.

crabmusket added a commit that referenced this pull request Mar 1, 2015

Merge pull request #1214 from bpay/cppcheck-cleaning
Fix some issues flagged by cppcheck

@crabmusket crabmusket merged commit 497a15c into GarageGames:development Mar 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment